Make a couple more fixes

hashicorp · Apr 24, 2024 · 661b74b · 661b74b
1 parent adc2cbc
commit 661b74b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/internal/service/elbv2/target_group.go b/internal/service/elbv2/target_group.go
@@ -345,9 +345,10 @@ func ResourceTargetGroup() *schema.Resource {
 										Default:  "off",
 									},
 									"minimum_healthy_targets_percentage": {
-										Type:     schema.TypeString,
-										Optional: true,
-										Default:  "off",
+										Type:         schema.TypeString,
+										Optional:     true,
+										Default:      "off",
+										ValidateFunc: validation.IntBetween(1, 100),
 									},
 								},
 							},
@@ -364,9 +365,10 @@ func ResourceTargetGroup() *schema.Resource {
 										Default:  1,
 									},
 									"minimum_healthy_targets_percentage": {
-										Type:     schema.TypeString,
-										Optional: true,
-										Default:  "off",
+										Type:         schema.TypeString,
+										Optional:     true,
+										Default:      "off",
+										ValidateFunc: validation.IntBetween(1, 100),
 									},
 								},
 							},
@@ -1369,8 +1371,8 @@ func expandTargetGroupHealthAttributes(tfMap map[string]interface{}) []*elbv2.Ta
 		if unhealthyStateRoutingMap, ok := targetGroupHealthMap["unhealthy_state_routing"].(map[string]interface{}); ok {
 			apiObjects = append(apiObjects,
 				&elbv2.TargetGroupAttribute{
-					Key:   aws.Int64("unhealthy_state_routing.minimum_healthy_targets_count"),
-					Value: aws.String(unhealthyStateRoutingMap["minimum_healthy_targets_count"].(string)),
+					Key:   aws.String("unhealthy_state_routing.minimum_healthy_targets_count"),
+					Value: flex.IntValueToString(unhealthyStateRoutingMap["minimum_healthy_targets_count"].(int)),
 				},
 				&elbv2.TargetGroupAttribute{
 					Key:   aws.String("unhealthy_state_routing.minimum_healthy_targets_percentage"),

diff --git a/internal/service/elbv2/target_group_test.go b/internal/service/elbv2/target_group_test.go
@@ -5111,13 +5111,13 @@ resource "aws_lb_target_group" "test" {
 
   target_group_health {
     dns_failover {
-      minimum_healthy_targets_count = %[2]s
-      minimum_healthy_targets_percentage = %[3]s
+      minimum_healthy_targets_count = %[2]q
+      minimum_healthy_targets_percentage = %[3]q
     }
 
     unhealthy_state_routing {
-      minimum_healthy_targets_count = %[4]d
-      minimum_healthy_targets_percentage = %[5]s
+      minimum_healthy_targets_count = %[4]q
+      minimum_healthy_targets_percentage = %[5]q
     }
   }
 }