Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
resource/aws_lb_listener_rule: Fix ALB listener rule update regression (
#11364) * Add some update tests. Issue #11323 New condition rule logic breaks when one a condition is present but *not* being updated. Includes single condition when the action is being modified. User is presented with: Error: Only one of field, host_header, http_header, http_request_method, path_pattern, query_string or source_ip can be set in a condition block * Handle rule updates when Condition not modified Fixes #11323 Fixes #11362 Output from acceptance testing: ``` --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (3.89s) --- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (4.41s) --- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (28.37s) --- PASS: TestAccAWSLBListenerRule_fixedResponse (175.92s) --- PASS: TestAccAWSLBListenerRule_basic (180.33s) --- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (180.49s) --- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (185.53s) --- PASS: TestAccAWSLBListenerRule_conditionHostHeader (187.50s) --- PASS: TestAccAWSLBListenerRule_cognito (190.30s) --- PASS: TestAccAWSLBListenerRule_updateRulePriority (196.64s) --- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (202.36s) --- PASS: TestAccAWSLBListenerRule_conditionPathPattern (209.18s) --- PASS: TestAccAWSLBListenerRule_Action_Order (210.40s) --- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (215.83s) --- PASS: TestAccAWSLBListenerRule_updateFixedResponse (221.31s) --- PASS: TestAccAWSLBListenerRule_redirect (225.96s) --- PASS: TestAccAWSLBListenerRule_oidc (226.93s) --- PASS: TestAccAWSLBListenerRule_conditionQueryString (208.73s) --- PASS: TestAccAWSLBListenerRule_conditionUpdatePathPattern_deprecated (240.20s) --- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (253.40s) --- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (260.08s) --- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (261.67s) --- PASS: TestAccAWSLBListenerRule_priority (280.50s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (177.25s) --- PASS: TestAccAWSLBListenerRule_conditionMultiple (190.69s) --- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (198.27s) --- PASS: TestAccAWSLBListenerRule_conditionSourceIp (208.93s) ```
- Loading branch information