Skip to content

Commit

Permalink
update platform id validation on signing_profile
Browse files Browse the repository at this point in the history
  • Loading branch information
phuongdnguyen committed Jul 7, 2023
1 parent dfd52e4 commit 480d446
Showing 1 changed file with 27 additions and 9 deletions.
36 changes: 27 additions & 9 deletions internal/service/signer/signing_profile.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func ResourceSigningProfile() *schema.Resource {
Required: true,
ForceNew: true,
ValidateFunc: validation.StringInSlice([]string{
"AWSLambda-SHA384-ECDSA"},
"AWSLambda-SHA384-ECDSA", "Notation-OCI-SHA384-ECDSA", "AWSIoTDeviceManagement-SHA256-ECDSA", "AmazonFreeRTOS-TI-CC3220SF", "AmazonFreeRTOS-Default"},
false),
},
"name": {
Expand Down Expand Up @@ -89,6 +89,11 @@ func ResourceSigningProfile() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"signing_material": {
Type: schema.TypeString,
Computed: true,
Optional: true,
},
"platform_display_name": {
Type: schema.TypeString,
Computed: true,
Expand Down Expand Up @@ -154,6 +159,13 @@ func resourceSigningProfileCreate(ctx context.Context, d *schema.ResourceData, m
}
}

if v, exists := d.GetOk("signing_material"); exists {
signingMaterial := v.(string)
signingProfileInput.SigningMaterial = &signer.SigningMaterial{
CertificateArn: &signingMaterial,
}
}

_, err := conn.PutSigningProfileWithContext(ctx, signingProfileInput)
if err != nil {
return sdkdiag.AppendErrorf(diags, "creating Signer signing profile: %s", err)
Expand Down Expand Up @@ -185,14 +197,15 @@ func resourceSigningProfileRead(ctx context.Context, d *schema.ResourceData, met
if err := d.Set("platform_id", signingProfileOutput.PlatformId); err != nil {
return sdkdiag.AppendErrorf(diags, "setting signer signing profile platform id: %s", err)
}

if err := d.Set("signature_validity_period", []interface{}{
map[string]interface{}{
"value": signingProfileOutput.SignatureValidityPeriod.Value,
"type": signingProfileOutput.SignatureValidityPeriod.Type,
},
}); err != nil {
return sdkdiag.AppendErrorf(diags, "setting signer signing profile signature validity period: %s", err)
if signingProfileOutput.SignatureValidityPeriod != nil {
if err := d.Set("signature_validity_period", []interface{}{
map[string]interface{}{
"value": signingProfileOutput.SignatureValidityPeriod.Value,
"type": signingProfileOutput.SignatureValidityPeriod.Type,
},
}); err != nil {
return sdkdiag.AppendErrorf(diags, "setting signer signing profile signature validity period: %s", err)
}
}

if err := d.Set("platform_display_name", signingProfileOutput.PlatformDisplayName); err != nil {
Expand All @@ -218,6 +231,11 @@ func resourceSigningProfileRead(ctx context.Context, d *schema.ResourceData, met
if err := d.Set("status", signingProfileOutput.Status); err != nil {
return sdkdiag.AppendErrorf(diags, "setting signer signing profile status: %s", err)
}
if signingProfileOutput.SigningMaterial != nil {
if err := d.Set("signing_material", signingProfileOutput.SigningMaterial.CertificateArn); err != nil {
return sdkdiag.AppendErrorf(diags, "setting signer signing profile material: %s", err)
}
}

setTagsOut(ctx, signingProfileOutput.Tags)

Expand Down

0 comments on commit 480d446

Please sign in to comment.