Skip to content

Commit

Permalink
r/aws_batch_job_definition: Verify that default value of 'propagate_t…
Browse files Browse the repository at this point in the history
…ags' is false in acceptance tests.
  • Loading branch information
ewbankkit committed Apr 19, 2021
1 parent 3615015 commit 41f2c4e
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions aws/resource_aws_batch_job_definition_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ func TestAccAWSBatchJobDefinition_basic(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "name", rName),
resource.TestCheckResourceAttr(resourceName, "parameters.%", "0"),
resource.TestCheckResourceAttr(resourceName, "platform_capabilities.#", "0"),
resource.TestCheckResourceAttr(resourceName, "propagate_tags", "false"),
resource.TestCheckResourceAttr(resourceName, "retry_strategy.#", "0"),
resource.TestCheckResourceAttrSet(resourceName, "revision"),
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
Expand Down Expand Up @@ -151,6 +152,7 @@ func TestAccAWSBatchJobDefinition_PlatformCapabilities_EC2(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "parameters.%", "0"),
resource.TestCheckResourceAttr(resourceName, "platform_capabilities.#", "1"),
resource.TestCheckTypeSetElemAttr(resourceName, "platform_capabilities.*", "EC2"),
resource.TestCheckResourceAttr(resourceName, "propagate_tags", "false"),
resource.TestCheckResourceAttr(resourceName, "retry_strategy.#", "0"),
resource.TestCheckResourceAttrSet(resourceName, "revision"),
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
Expand Down Expand Up @@ -188,6 +190,7 @@ func TestAccAWSBatchJobDefinition_PlatformCapabilities_Fargate(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "parameters.%", "0"),
resource.TestCheckResourceAttr(resourceName, "platform_capabilities.#", "1"),
resource.TestCheckTypeSetElemAttr(resourceName, "platform_capabilities.*", "FARGATE"),
resource.TestCheckResourceAttr(resourceName, "propagate_tags", "false"),
resource.TestCheckResourceAttr(resourceName, "retry_strategy.#", "0"),
resource.TestCheckResourceAttrSet(resourceName, "revision"),
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
Expand Down Expand Up @@ -360,7 +363,17 @@ func TestAccAWSBatchJobDefinition_PropagateTags(t *testing.T) {
Config: testAccBatchJobDefinitionPropagateTags(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckBatchJobDefinitionExists(resourceName, &jd),
testAccMatchResourceAttrRegionalARN(resourceName, "arn", "batch", regexp.MustCompile(fmt.Sprintf(`job-definition/%s:\d+`, rName))),
resource.TestCheckResourceAttrSet(resourceName, "container_properties"),
resource.TestCheckResourceAttr(resourceName, "name", rName),
resource.TestCheckResourceAttr(resourceName, "parameters.%", "0"),
resource.TestCheckResourceAttr(resourceName, "platform_capabilities.#", "0"),
resource.TestCheckResourceAttr(resourceName, "propagate_tags", "true"),
resource.TestCheckResourceAttr(resourceName, "retry_strategy.#", "0"),
resource.TestCheckResourceAttrSet(resourceName, "revision"),
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
resource.TestCheckResourceAttr(resourceName, "timeout.#", "0"),
resource.TestCheckResourceAttr(resourceName, "type", "container"),
),
},
},
Expand Down

0 comments on commit 41f2c4e

Please sign in to comment.