Merge branch 'hashicorp:main' into b-include_bitrate_and_sample_rate_…

…for_aac

.actrc

@@ -1,3 +1,3 @@
 # Needed for testing our workflows
 -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-22.04
--P medium=ghcr.io/catthehacker/ubuntu:act-22.04
+-P linux=ghcr.io/catthehacker/ubuntu:act-22.04

.changelog/20891.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_cloudhsm_v2_hsm: Enforce `ExactlyOneOf` for `availability_zone` and `subnet_id` arguments
+```

.changelog/25535.txt

@@ -0,0 +1,3 @@
+```release-note:new-data-source
+aws_servicecatalog_provisioning_artifacts
+```

.changelog/26305.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_instance: Add ability to update `private_dns_name_options` in place
+```

.changelog/26746.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+data-source/aws_opensearch_domain: Add missing `advanced_security_options.anonymous_auth_enabled` attribute
+```

.changelog/27207.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_batch_compute_environment: Allow a maximum of 2 `compute_resources.ec2_configuration`s
+```

.changelog/27351.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_ecs_task_definition: Add `arn_without_revision` attribute
+```

.changelog/27598.txt

@@ -0,0 +1,7 @@
+```release-note:bug
+resource/aws_elasticsearch_domain: Remove upper bound validation for `ebs_options.throughput` as the 1,000 MB/s limit can be raised
+```
+
+```release-note:bug
+resource/aws_opensearch_domain: Remove upper bound validation for `ebs_options.throughput` as the 1,000 MB/s limit can be raised
+```

.changelog/27616.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_appflow_flow: Add attribute `preserve_source_data_typing` to `s3_output_format_config` in `s3`
+```

.changelog/27790.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_cognito_user_pool_domain: Add `cloudfront_distribution` and `cloudfront_distribution_zone_id` attributes
+```

.changelog/28245.txt

@@ -0,0 +1,7 @@
+```release-note:new-data-source
+aws_ec2_public_ipv4_pools
+```
+
+```release-note:new-data-source
+aws_ec2_public_ipv4_pool
+```

.changelog/28424.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/db_snapshot: Add `shared_accounts` argument
+```

.changelog/28434.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_db_instance: Add `listener_endpoint` attribute
+```
+
+```release-note:enhancement
+resource/aws_db_instance: Add plan time validations for `backup_retention_period`, `monitoring_interval`, and `monitoring_role_arn`
+```

.changelog/28621.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_transfer_server: Add `protocol_details` argument
+```

.changelog/28812.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_sesv2_configuration_set: Add `vdm_options` argument
+```

.changelog/28961.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_inspector2_organization_configuration: Add `lambda` attribute to `auto_enable` configuration block
+```

.changelog/29254.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_flow_log: Add `deliver_cross_account_role` argument
+```
+
+```release-note:bug
+resource/aws_flow_log: Fix IAM eventual consistency errors on resource Create
+```

.changelog/29291.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+data-source/aws_ce_cost_category: Add `default_value` attribute
+```

.changelog/29566.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_glue_crawler: Add `create_native_delta_table` attribute to the `delta_target` configuration block
+```

.changelog/29632.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_s3_bucket: Add error handling for `XNotImplemented` errors when reading `acceleration_status`, `request_payer`, `lifecycle_rule`, `logging`, or `replication_configuration` into terraform state.
+```

.changelog/29635.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_qldb_ledger: Add configurable timeouts
+```

.changelog/29648.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+data-source/aws_ec2_transit_gateway_attachment: Add `association_state` and `association_transit_gateway_route_table_id` attributes
+```

.changelog/29656.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_codegurureviewer_repository_association
+```

.changelog/29670.txt

@@ -0,0 +1,3 @@
+```release-note:new-resource
+aws_oam_sink
+```

.changelog/29692.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_transfer_workflow: Add `decrypt_step_details` to the `on_exception_steps` and `steps` configuration blocks
+```

.changelog/29735.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_apigatewayv2_integration: Retry errors like `ConflictException: Unable to complete operation due to concurrent modification. Please try again later.`
+```

.changelog/29741.txt

@@ -0,0 +1,19 @@
+```release-note:new-resource
+aws_licensemanager_grant
+```
+
+```release-note:new-resource
+aws_licensemanager_grant_accepter
+```
+
+```release-note:new-data-source
+aws_licensemanager_received_license
+```
+
+```release-note:new-data-source
+aws_licensemanager_received_licenses
+```
+
+```release-note:new-data-source
+aws_licensemanager_grants
+```

.changelog/29763.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_acm_certificate: Change `options` to `Computed`
+```
+
+```release-note:bug
+resource/aws_acm_certificate: Update `options.certificate_transparency_logging_preference` in place rather than replacing the resource
+```

.changelog/29783.txt

@@ -0,0 +1,3 @@
+```release-note:new-data-source
+aws_ecs_task_execution
+```

.changelog/29793.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_grafana_workspace: Add `network_access_control` argument
+```
+
+```release-note:bug
+resource/aws_grafana_workspace: Allow removing `vpc_configuration` 
+```

.changelog/29794.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+data-source/aws_instances: Add `ipv6_addresses` attribute
+```

.changelog/29808.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_medialive_channel: Fix setting of the `include_fec` attribute in `fec_output_settings`
+```

.changelog/29812.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lambda_function: Prevent `Provider produced inconsistent final plan` errors produced by null `skip_destroy` attribute value. NOTE: Because the maintainers have been unable to reproduce the reported problem, the fix is best effort and we ask for community support in verifying the fix.
+```

.changelog/29820.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_batch_job_definition: Prevents perpetual diff when container properties environment variable has empty value.
+```

.changelog/29824.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_medialive_channel: Fix setting of the `video_pid` attribute in `m2ts_settings`
+```

.changelog/29839.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lambda_function: Fix empty environment variable update
+```

.changelog/29863.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_elastic_beanstalk_configuration_template: Map errors like `InvalidParameterValue: No Platform named '...' found.` to `resource.NotFoundError` so `terraform refesh` correctly removes the resource from state
+```

.changelog/29867.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_opensearch_domain: Add `dashboard_endpoint` attribute
+```
+
+```release-note:enhancement
+data-source/aws_opensearch_domain: Add `dashboard_endpoint` attribute
+```

.changelog/29903.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_lightsail_instance: Fix `name` validation to allow instances to start with a numeric character
+```

.changelog/29915.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_sagemaker_endpoint_configuration: Fix `variant_name` generation when unset
+```

.changelog/29920.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_lb_target_group: Add `load_balancing_cross_zone_enabled` argument
+```

.changelog/29924.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+resource/aws_dynamodb_table: Add `deletion_protection_enabled` argument
+```
+
+```release-note:enhancement
+data-source/aws_dynamodb_table: Add `deletion_protection_enabled` attribute
+```

.changelog/29926.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_fms_policy: Add `description` argument
+```

.changelog/92814.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_amplify_domain_association: Add `enable_auto_sub_domain` argument
+```

.ci/.golangci2.yml

@@ -9,9 +9,6 @@ issues:
     - linters:
         - unparam
       text: "always receives"
-    - path: _test\.go
-      linters:
-        - contextcheck
   max-per-linter: 0
   max-same-issues: 0
 

.ci/.semgrep-service-name0.yml

@@ -2709,6 +2709,64 @@ rules:
           patterns:
             - pattern-regex: "(?i)codedeploy"
     severity: WARNING
+  - id: codegurureviewer-in-func-name
+    languages:
+      - go
+    message: Do not use "CodeGuruReviewer" in func name inside codegurureviewer package
+    paths:
+      include:
+        - internal/service/codegurureviewer
+    patterns:
+      - pattern: func $NAME( ... ) { ... }
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)CodeGuruReviewer"
+            - pattern-not-regex: ^TestAcc.*
+    severity: WARNING
+  - id: codegurureviewer-in-test-name
+    languages:
+      - go
+    message: Include "CodeGuruReviewer" in test name
+    paths:
+      include:
+        - internal/service/codegurureviewer/*_test.go
+    patterns:
+      - pattern: func $NAME( ... ) { ... }
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-not-regex: "^TestAccCodeGuruReviewer"
+            - pattern-regex: ^TestAcc.*
+    severity: WARNING
+  - id: codegurureviewer-in-const-name
+    languages:
+      - go
+    message: Do not use "CodeGuruReviewer" in const name inside codegurureviewer package
+    paths:
+      include:
+        - internal/service/codegurureviewer
+    patterns:
+      - pattern: const $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)CodeGuruReviewer"
+    severity: WARNING
+  - id: codegurureviewer-in-var-name
+    languages:
+      - go
+    message: Do not use "CodeGuruReviewer" in var name inside codegurureviewer package
+    paths:
+      include:
+        - internal/service/codegurureviewer
+    patterns:
+      - pattern: var $NAME = ...
+      - metavariable-pattern:
+          metavariable: $NAME
+          patterns:
+            - pattern-regex: "(?i)CodeGuruReviewer"
+    severity: WARNING
   - id: codepipeline-in-func-name
     languages:
       - go
@@ -3202,48 +3260,3 @@ rules:
           patterns:
             - pattern-regex: "(?i)ConfigService"
     severity: WARNING
-  - id: configservice-in-var-name
-    languages:
-      - go
-    message: Do not use "ConfigService" in var name inside configservice package
-    paths:
-      include:
-        - internal/service/configservice
-    patterns:
-      - pattern: var $NAME = ...
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)ConfigService"
-    severity: WARNING
-  - id: connect-in-func-name
-    languages:
-      - go
-    message: Do not use "Connect" in func name inside connect package
-    paths:
-      include:
-        - internal/service/connect
-    patterns:
-      - pattern: func $NAME( ... ) { ... }
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-regex: "(?i)Connect"
-            - pattern-not-regex: .*uickConnect.*
-            - pattern-not-regex: ^TestAcc.*
-    severity: WARNING
-  - id: connect-in-test-name
-    languages:
-      - go
-    message: Include "Connect" in test name
-    paths:
-      include:
-        - internal/service/connect/*_test.go
-    patterns:
-      - pattern: func $NAME( ... ) { ... }
-      - metavariable-pattern:
-          metavariable: $NAME
-          patterns:
-            - pattern-not-regex: "^TestAccConnect"
-            - pattern-regex: ^TestAcc.*
-    severity: WARNING