Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calls to t.Helper() in defered functions #293

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

ewbankkit
Copy link
Contributor

Adds missing calls to t.Helper() in two defered functions.

Closes #292.

% go test ./...
?   	github.com/hashicorp/terraform-plugin-testing/helper/logging	[no test files]
ok  	github.com/hashicorp/terraform-plugin-testing/config	2.009s
ok  	github.com/hashicorp/terraform-plugin-testing/helper/acctest	2.362s
?   	github.com/hashicorp/terraform-plugin-testing/internal/addrs	[no test files]
?   	github.com/hashicorp/terraform-plugin-testing/internal/testing	[no test files]
?   	github.com/hashicorp/terraform-plugin-testing/internal/testing/testprovider	[no test files]
?   	github.com/hashicorp/terraform-plugin-testing/internal/testing/testsdk	[no test files]
?   	github.com/hashicorp/terraform-plugin-testing/internal/testing/testsdk/datasource	[no test files]
?   	github.com/hashicorp/terraform-plugin-testing/internal/testing/testsdk/provider	[no test files]
?   	github.com/hashicorp/terraform-plugin-testing/internal/testing/testsdk/providerserver	[no test files]
?   	github.com/hashicorp/terraform-plugin-testing/internal/testing/testsdk/resource	[no test files]
ok  	github.com/hashicorp/terraform-plugin-testing/helper/resource	95.516s
ok  	github.com/hashicorp/terraform-plugin-testing/internal/configs/configschema	0.644s
ok  	github.com/hashicorp/terraform-plugin-testing/internal/configs/hcl2shim	2.394s
ok  	github.com/hashicorp/terraform-plugin-testing/internal/logging	0.924s
ok  	github.com/hashicorp/terraform-plugin-testing/internal/plugintest	10.395s
ok  	github.com/hashicorp/terraform-plugin-testing/internal/teststep	1.521s
ok  	github.com/hashicorp/terraform-plugin-testing/internal/tfdiags	1.910s
ok  	github.com/hashicorp/terraform-plugin-testing/knownvalue	2.024s
ok  	github.com/hashicorp/terraform-plugin-testing/plancheck	8.467s
ok  	github.com/hashicorp/terraform-plugin-testing/statecheck	5.476s
ok  	github.com/hashicorp/terraform-plugin-testing/terraform	4.563s
ok  	github.com/hashicorp/terraform-plugin-testing/tfjsonpath	4.606s
ok  	github.com/hashicorp/terraform-plugin-testing/tfversion	129.643s

@ewbankkit ewbankkit requested a review from a team as a code owner February 22, 2024 19:21
@austinvalle austinvalle added this to the v1.7.0 milestone Feb 29, 2024
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 - I pushed a small changelog for the fix, thanks @ewbankkit

@austinvalle austinvalle merged commit ff585cf into hashicorp:main Feb 29, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing.T.Helper() not called in defered functions
2 participants