Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
helper/resource: Remove special timeouts logic in TestStep ImportStat…
…eVerify Reference: hashicorp/terraform-plugin-sdk#1146 Reference: hashicorp/terraform-plugin-sdk#1147 This change reverts hashicorp/terraform-plugin-sdk#576 as it prevents acceptance testing from detecting Terraform 1.3.8 and later potentially returning an unexpected plan after import involving the `timeouts` block. hashicorp/terraform-plugin-sdk#1146 fixes the import logic to never include a known value for `timeouts`, which is what the acceptance testing was trying to say when this testing logic was not in place. With this change, but without hashicorp/terraform-plugin-sdk#1146 on a resource known to have the unexpected plan after import on Terraform 1.3.8: ``` === CONT TestAccVPCSecurityGroup_basic vpc_security_group_test.go:1002: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import. map[string]string{ + "timeouts.%": "2", } --- FAIL: TestAccVPCSecurityGroup_basic (21.54s) ``` With this change and with hashicorp/terraform-plugin-sdk#1146: ``` === CONT TestAccVPCSecurityGroup_basic --- PASS: TestAccVPCSecurityGroup_basic (20.23s) ``` Verified both ways on Terraform 1.2.9 as well (as a smoke test for a Terraform version prior to 1.3.8).
- Loading branch information