Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump terraform-exec to 0.14.0 #775

Merged
merged 1 commit into from
Jun 25, 2021
Merged

deps: Bump terraform-exec to 0.14.0 #775

merged 1 commit into from
Jun 25, 2021

Conversation

radeksimko
Copy link
Member

This makes the SDK (or more specifically the test framework) compatible with Terraform 1.0.1 as per hashicorp/terraform-exec#194 and hashicorp/terraform-json#37 and hashicorp/terraform#28889

This also fixes the following test currently panicking on main:

--- FAIL: TestParallelTest (1.59s)
panic: testing.T failed, see logs for output (if any) [recovered]
	panic: testing.T failed, see logs for output (if any)

goroutine 138 [running]:
testing.tRunner.func1.1(0x1c29e80, 0x1f93c30)
	/Users/radeksimko/.goenv/versions/1.15.8/src/testing/testing.go:1072 +0x30d
testing.tRunner.func1(0xc0000e8f00)
	/Users/radeksimko/.goenv/versions/1.15.8/src/testing/testing.go:1075 +0x41a
panic(0x1c29e80, 0x1f93c30)
	/Users/radeksimko/.goenv/versions/1.15.8/src/runtime/panic.go:969 +0x1b9
github.com/mitchellh/go-testing-interface.(*RuntimeT).FailNow(...)
	/Users/radeksimko/gopath/pkg/mod/github.com/mitchellh/go-testing-interface@v1.0.4/testing_go19.go:64
github.com/mitchellh/go-testing-interface.(*RuntimeT).Fatalf(0xc0001229e0, 0x1e3c41a, 0x3b, 0xc0005705a0, 0x1, 0x1)
	/Users/radeksimko/gopath/pkg/mod/github.com/mitchellh/go-testing-interface@v1.0.4/testing_go19.go:78 +0x70
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.runNewTest.func1(0x1fdf880, 0xc0001229e0, 0xc00008ee40, 0xc000131c90)
	/Users/radeksimko/gopath/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/testing_new.go:56 +0x1fa
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.runNewTest(0x1fdf880, 0xc0001229e0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/radeksimko/gopath/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/testing_new.go:150 +0x45e
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.Test(0x1fdf880, 0xc0001229e0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/radeksimko/gopath/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/testing.go:558 +0x3e5
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.ParallelTest(0x1fdf880, 0xc0001229e0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/radeksimko/gopath/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/testing.go:496 +0xb8
github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.TestParallelTest(0xc0000e8f00)
	/Users/radeksimko/gopath/src/github.com/hashicorp/terraform-plugin-sdk/helper/resource/testing_test.go:29 +0x85
testing.tRunner(0xc0000e8f00, 0x1e540d8)
	/Users/radeksimko/.goenv/versions/1.15.8/src/testing/testing.go:1123 +0xef
created by testing.(*T).Run
	/Users/radeksimko/.goenv/versions/1.15.8/src/testing/testing.go:1168 +0x2b3
FAIL	github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource	2.909s
FAIL

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants