basetypes: fix equality for values with nil elementType #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jar-b
changed the title
bendbennett
reviewed
Mar 19, 2024
|
Thanks @bendbennett - added separate changelog entries for each type. Let me know if you'd prefer a single entry instead! |
|
@bendbennett / @jar-b anything else need to happen here? Implementation change looks good to me 😄 |
A `MapValue` with a nil `elementType` is an invalid state, and therefore cannot verify equality with another value. This change to the `MapValue.Equal` method now returns `false` if either the receiver or argument have a nil `elementType`.
|
Apologies, I missed that this needed rebased. Should be ready now! |
austinvalle
approved these changes
Apr 17, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
MapValue,ListValue, orSetValuewith a nilelementTypeis an invalid state, and therefore cannot verify equality with another value. These changes to theEqualmethod now returnsfalseif either the receiver or argument have a nilelementType.Closes #959