Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Further clarify SDK migration testing of data sources #877

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 21, 2023

Closes #875

The purpose of this additional documentation is two-fold:

  • Showing how to perform migration testing of full data source data, using the terraform_data managed resource
  • Recommending that developers should instead prefer individual attribute value testing for data sources

Reference: #875

The purpose of this additional documentation is two-fold:

- Showing how to perform migration testing of full data source data, using the `terraform_data` managed resource
- Recommending that developers should instead prefer individual attribute value testing for data sources
@bflad bflad added the documentation Improvements or additions to documentation label Nov 21, 2023
@bflad bflad added this to the v1.5.0 milestone Nov 21, 2023
@bflad bflad requested a review from a team as a code owner November 21, 2023 15:30
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad merged commit 1df425a into main Nov 21, 2023
2 checks passed
@bflad bflad deleted the bflad/migration-data-source-testing branch November 21, 2023 15:54
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing Migration (from SDKv2) of Datasources does not fail when fields are missing
2 participants