reflect: Use float64
string representation for float32
reflection equivalency
#1015
+84
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #1014
This fixes a bug encountered when using
function.Float32Parameter
in a provider defined function, similar to issue #914:The current reflection logic for
float32
compares the reflection target's string representation of thefloat32
value with the string representation of that same value in a newbig.Float
object and throws an error if the representations differ. Creating a newbig.Float
object requires a conversion fromfloat32
tofloat64
resulting in precision loss and differing string representations.This PR switches the string comparisons to
float64
and adds overflow and underflow checks forfloat32
.