Better support for errors.Is and errors.As #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Sep 30, 2020
There was a problem hiding this comment.
I'm ok with merging this (once test failures are addressed) - I suppose it's useful to have a single errors.Is/errors.As on the consumer side as opposed to two, but my main concern was lack of context in error messaging resulting from the default errors from stdlib.
I will address that differently in a different PR.
|
The test failure here is that interruption of |
|
Of course this succeeds in Windows which is where I wrote it 😭 I'll have to switch over to WSL and see whats up on linux. |
paultyng
force-pushed
the
unwrap
branch
3 times, most recently
from
aa8df1d
to
06a9b9b
Compare
kmoe
reviewed
Oct 9, 2020
paultyng
force-pushed
the
unwrap
branch
2 times, most recently
from
da9aaae
to
a413f00
Compare
|
@kmoe this is cleaned up now and passes with your plan file test fixes. |
paultyng
force-pushed
the
unwrap
branch
5 times, most recently
from
07d6f35
to
e2d9efc
Compare
And respond to errors.Is for Context errors
kmoe
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially supersedes #91
Probably best to review individual commits, the first commit splits exported errors to two files, one for exit error wrappers and one for the rest. No other changes beyond comments. The second commit adds the support for unwrapping and
errors.Iscomparisons.