This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
Add Vault agent configuration #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
reviewed
Apr 12, 2019
… to file and add double quotes to bash variable
…y+pasted from another example
|
Looks like tests passed. Merging now, thank you! |
|
My pleasure! Likewise, thank you for the quick review and merge! I've updated my scripts to point to the latest release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133. This adds support for installing as a Vault agent. Currently, only auto-auth is supported (this doesn't add in support for caching).
I had to update to Vault 1.1.0, since it seems there was some bug with the Vault agent not respecting the Vault address in the config file.
I added a Vault agent test, which was mostly copy+pasted from the IAM auth test, with the only change being the use of Vault agent instead of hitting the Vault API using
curl.For testing, I only ran the Vault agent test using the Amazon Linux 2 image, and the EC2 Auth test using both the Amazon Linux 2 and Ubuntu images.