-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajsanon/ux updates #80
Conversation
- removed all provisioners and used providers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
@@ -6,9 +6,10 @@ variable "name" { | |||
type = string | |||
} | |||
|
|||
variable "ecr_image_uri" { | |||
description = "The private ECR image URI for consul-lambda-registrator." | |||
variable "lambda_registrator_image" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a breaking change to me. We should probably mark it as a breaking change in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also assuming this breaks the acceptance tests
ecr_image_uri = var.ecr_image_uri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I missed this in my review. We need to open a PR to update the CHANGELOG for this.
target_image = local.ecr_image_uri | ||
} | ||
|
||
resource "null_resource" "push_image" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We originally didn't include this because it breaks TFC. It looks like this PR only allows using a pull through cache or pushing docker images. This effectively requires TFC users to use the pull through cache approach.
Is this a tradeoff we are ok with?
* Lambda Reg UX changes to simplify for users * - added pull through cache - removed all provisioners and used providers * bumped lambda_registrator_image tag * fixed terraform fmt * moved providers to examples/lambda providers.tf * fixed provider and other minor fixes * added pull_through var in examples * fixed terraform lint * fix minor fmt issues * review fixes * minor name change * fix tf lint * variable name changes * added changelog --------- Co-authored-by: AJ Sanon <aj.sanon@hashicorp.com>
* bump version of setup-terraform and remove gotestsum retries * Update SSM Set to allow for Advanced Tier Parameters (#78) * Bump github.com/hashicorp/consul from 1.15.2 to 1.15.3 in /consul-lambda (#75) Bumps [github.com/hashicorp/consul](https://github.com/hashicorp/consul) from 1.15.2 to 1.15.3. - [Release notes](https://github.com/hashicorp/consul/releases) - [Changelog](https://github.com/hashicorp/consul/blob/main/CHANGELOG.md) - [Commits](hashicorp/consul@v1.15.2...v1.15.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/consul dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump google.golang.org/grpc from 1.50.1 to 1.53.0 in /test/acceptance (#79) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.1 to 1.53.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.50.1...v1.53.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Ajsanon/ux updates (#80) * Lambda Reg UX changes to simplify for users * - added pull through cache - removed all provisioners and used providers * bumped lambda_registrator_image tag * fixed terraform fmt * moved providers to examples/lambda providers.tf * fixed provider and other minor fixes * added pull_through var in examples * fixed terraform lint * fix minor fmt issues * review fixes * minor name change * fix tf lint * variable name changes * added changelog --------- Co-authored-by: AJ Sanon <aj.sanon@hashicorp.com> * Revert "Ajsanon/ux updates (#80)" (#81) This reverts commit db2b43a. * Add support for pushing `consul-lambda-registrator` public image to p… (#82) * Add support for pushing `consul-lambda-registrator` public image to private ecr repo through terraform * fmt tf * minor readme fix * addressed review comments * added fixes and fixed acceptance test * updated aws provider version * updated aws provider version * added force_delete to aws_ecr_repository in test * fmt tf * Update modules/lambda-registrator/main.tf Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com> * Update modules/lambda-registrator/main.tf Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com> * Update modules/lambda-registrator/variables.tf Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com> * grouped data sources together * added review changes * add some fixes * test fixes * minor test fix * added default "" to test ecr_image_uri * fmt tf * Update modules/lambda-registrator/main.tf Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com> * added validation test * fixed tf fmt and made validation test parallel * removed validation test from basic test * added test case to validate when privateEcrReponame is set * updated enable_auto_publish_ecr_image var description * fixed tf fmt * Update modules/lambda-registrator/variables.tf Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com> * changed consul_image version in basic_test --------- Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com> * Update to use CRT prepare workflow This update, moves consul-dataplane to use the prepare workflow. This workflow encapsulates several previous workflows, running jobs in parallel to reduce the artifact processing time. See https://hashicorp.atlassian.net/wiki/spaces/RELENG/pages/2489712686/Dec+7th+2022+-+Introducing+the+new+Prepare+workflow for more info. * [COMPLIANCE] Add Copyright and License Headers (#83) Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /test/acceptance (#85) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * NET-7753 - Support for arm64 builds (#90) * support for arm64 init * fix runs on * fix runs on * fix lint-consul-retry * removed arch * add self hosted machine * fix os * fix platform * fix -race * session manager fix * unzip with overwrite flag * fix vpc issue * arm self hosted * remvoed -override * using docker/setup-qemu-action (#91) * using docker/setup-qemu-action * minor fix * minor fix * minor fix * refactor * added emulation to terrafrom-ci * remveod unused env variable * changed working directory for unit tests * not pushing arm image to hashicorpdev * building arm and amd binaries for extension and lambda for acc test * minor workflow fix * temp change * passing arch to lambda funcs * fmt tf * passing arch through preexisting lambda * fix tf * changed lambda runtime * changed lambda binary name bootstrap * fix go build * reverted extension build changes * increased lambda timeout * removed timeout from lambda func * fmt tf * changed lambda handler * updated aws -lambda-go lib * minor refactor * removed unused step matrix strategy and added some comments * setting unique name for private ecr repo * setting arch for buildig registrator image * temp fix * building arm * docker buildx setup * fixed docker build * fix makefile * fix makefile * bumped aws-lambda-go lib version * temp fix * makefile change * test * modifief registrator tf to support arch * added back other tc * increased timeout * changhed timeout * adjusted timeout * increased timeout * bumped consul image version * removed emulation from acc test * fix tf ci * fix tf ci * increased lambda timeout * increade timeout * making registrator amd64 * temp removed arm regist * readded emulation * reverted some changes * restored eralier version of consul * added arm reg * passed arch to reg * tf fmt * removed arch in ecr tf * removed arch * only amd * add max paralle 1 * fix arch * fix makefile * added buildx * added back emulation * max p 1 * only arm * increase timeout * dummy commit to trigger CI * using different docker tga * fix arch in docker tag * docker push correct arch * fix output * fix image tag * fixed arch var * added multiarch build * fmt tf * fix docker build * build fix * increased timeout * skipped test * removed arch unit tests * removed specifying arch in registrator module * removed passing arch to registrator * readded reg arch * fixed p[assing arch * reenabled arm test for autopublish * fmt tf * fixed validation --------- Co-authored-by: aahel <aahel.guha@hashicorp.com> * prerelease version change * updated changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Chris Thain <chris.m.thain@gmail.com> Co-authored-by: Ryan Eskin <55214537+reskin89@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: AJ Sanon <aj.sanon@hashicorp.com> Co-authored-by: Chris Thain <32781396+cthain@users.noreply.github.com> Co-authored-by: Sarah Thompson <sthompson@hashicorp.com> Co-authored-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com> Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com>
Changes proposed in this PR:
https://hashicorp.atlassian.net/browse/NET-256
How I've tested this PR:
test by creating running terraform apply using aws sandbox account. tested with pull_through = false and pull_through=true.
How I expect reviewers to test this PR:
Checklist: