-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go-version and address CVE #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are still going to fail until Consul 1.15 is out |
wilkermichael
temporarily deployed
to
dockerhub/hashicorpdev
February 21, 2023 22:35
— with
GitHub Actions
Inactive
wilkermichael
force-pushed
the
mw/update-go-version
branch
from
February 21, 2023 23:26
64d0596
to
80e76ff
Compare
wilkermichael
temporarily deployed
to
dockerhub/hashicorpdev
February 21, 2023 23:29
— with
GitHub Actions
Inactive
wilkermichael
temporarily deployed
to
dockerhub/hashicorpdev
February 21, 2023 23:35
— with
GitHub Actions
Inactive
wilkermichael
requested review from
a team,
marianoasselborn and
mdeggies
and removed request for
a team
February 21, 2023 23:56
wilkermichael
force-pushed
the
mw/update-go-version
branch
from
February 21, 2023 23:57
2ea5b34
to
4c4f949
Compare
wilkermichael
temporarily deployed
to
dockerhub/hashicorpdev
February 22, 2023 00:00
— with
GitHub Actions
Inactive
wilkermichael
force-pushed
the
mw/update-go-version
branch
2 times, most recently
from
February 22, 2023 00:07
06a1c08
to
fd0169b
Compare
wilkermichael
temporarily deployed
to
dockerhub/hashicorpdev
February 22, 2023 00:10
— with
GitHub Actions
Inactive
- fix pipeline tests to use go-version in .go-version file - fixed pathing for .go-version, this wasn't being correctly used
wilkermichael
force-pushed
the
mw/update-go-version
branch
from
February 22, 2023 00:12
fd0169b
to
72405d2
Compare
@cthain ready for review whenever you have time, no rush |
wilkermichael
temporarily deployed
to
dockerhub/hashicorpdev
February 22, 2023 00:15
— with
GitHub Actions
Inactive
cthain
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @wilkermichael!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Tests are going to fail until Consul 1.15 is released
How I've tested this PR:
👀 & verified that all tests are pulling the correct Go version
How I expect reviewers to test this PR:
👀
Checklist: