Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-version and address CVE #54

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

wilkermichael
Copy link
Contributor

@wilkermichael wilkermichael commented Feb 21, 2023

Changes proposed in this PR:

Tests are going to fail until Consul 1.15 is released

How I've tested this PR:

👀 & verified that all tests are pulling the correct Go version

How I expect reviewers to test this PR:

👀

Checklist:

  • [n/a] Tests added
  • CHANGELOG entry added

@wilkermichael wilkermichael requested review from cthain and a team February 21, 2023 22:32
@wilkermichael
Copy link
Contributor Author

Tests are still going to fail until Consul 1.15 is out

@wilkermichael wilkermichael temporarily deployed to dockerhub/hashicorpdev February 21, 2023 22:35 — with GitHub Actions Inactive
@wilkermichael wilkermichael temporarily deployed to dockerhub/hashicorpdev February 21, 2023 23:29 — with GitHub Actions Inactive
@wilkermichael wilkermichael temporarily deployed to dockerhub/hashicorpdev February 21, 2023 23:35 — with GitHub Actions Inactive
@wilkermichael wilkermichael requested review from a team, marianoasselborn and mdeggies and removed request for a team February 21, 2023 23:56
@wilkermichael wilkermichael temporarily deployed to dockerhub/hashicorpdev February 22, 2023 00:00 — with GitHub Actions Inactive
@wilkermichael wilkermichael force-pushed the mw/update-go-version branch 2 times, most recently from 06a1c08 to fd0169b Compare February 22, 2023 00:07
@wilkermichael wilkermichael temporarily deployed to dockerhub/hashicorpdev February 22, 2023 00:10 — with GitHub Actions Inactive
- fix pipeline tests to use go-version in .go-version file
- fixed pathing for .go-version, this wasn't being correctly used
@wilkermichael
Copy link
Contributor Author

wilkermichael commented Feb 22, 2023

@cthain ready for review whenever you have time, no rush

@wilkermichael wilkermichael temporarily deployed to dockerhub/hashicorpdev February 22, 2023 00:15 — with GitHub Actions Inactive
Copy link
Contributor

@cthain cthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @wilkermichael!!

@wilkermichael wilkermichael merged commit 98fdc3e into main Feb 22, 2023
@wilkermichael wilkermichael deleted the mw/update-go-version branch February 22, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants