Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed master to main workflow branch triggers #216

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Fixed master to main workflow branch triggers #216

merged 1 commit into from
Sep 17, 2022

Conversation

magnetikonline
Copy link
Contributor

  • Noted this project has now been moved from master to main as the mainline branch (yay!)
  • ...but found a few places where things still reference master. The GitHub workflows being the most pressing (as they are not currently running in these states).
  • Also removed a bit of YAML quoting that's not needed in strings.

@magnetikonline magnetikonline requested a review from a team as a code owner June 14, 2022 00:20
magnetikonline
magnetikonline commented Jun 14, 2022
View reviewed changes
.github/workflows/continuous-integration.yml

on:
push:
branches:
- master
- main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important change.

magnetikonline
magnetikonline commented Jun 14, 2022
View reviewed changes
.github/workflows/setup-terraform.yml

on:
push:
branches:
- master
- main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important change.

magnetikonline
magnetikonline commented Jun 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
magnetikonline
magnetikonline commented Jun 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
jpogran
jpogran requested changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the Github Actions branch updates!

Since that is the purpose of this PR, can you please revert the whitespace and quoting changes? They are not required for this changeset.

@magnetikonline
Copy link
Contributor Author

Done @jpogran

This was referenced Sep 17, 2022
Merged
Closed
@jpogran jpogran merged commit 4f5ea8b into hashicorp:main Sep 17, 2022
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpogran jpogran jpogran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnetikonline @jpogran