Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow proxy values to be set #147

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Allow proxy values to be set #147

merged 2 commits into from
Mar 4, 2022

Conversation

rabun788
Copy link
Contributor

@rabun788 rabun788 commented Feb 17, 2022 •
edited by jpogran
Loading

This action fails behind a proxy, this PR updates hashicorp/js-releases from 1.40 to 1.50 which should allow a proxy to be set.

  • bump hashicorp/js-releases from 1.40 to 1.50

Fixes #17

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jpogran jpogran self-assigned this Mar 4, 2022
@jpogran jpogran added the dependencies Pull requests that update a dependency file label Mar 4, 2022
@jpogran jpogran added this to the 1.4.0 milestone Mar 4, 2022
@jpogran jpogran changed the title bump hashicorp/js-releases from 1.40 to 1.50 Allow proxy values to be set Mar 4, 2022
@jpogran jpogran requested a review from dbanck March 4, 2022 01:04
@rabun788
Copy link
Contributor Author

rabun788 commented Mar 4, 2022

Thanks @jpogran !!!

rabun788 and others added 2 commits March 4, 2022 10:56
@rabun788 @jpogran
bump hashicorp/js-releases from 1.40 to 1.50
ee26d58 
fixes hashicorp#17
@jpogran
Run build
8d4ee82 
This updates the package-lock.json and runs the build system and tests.
@jpogran
Copy link
Collaborator

jpogran commented Mar 4, 2022

Thank for you the contribution @rabun788 !

I've updated the other dev dependencies in another PR so that this PR only addresses the proxy improvement

@jpogran jpogran merged commit 9cfb6b6 into hashicorp:main Mar 4, 2022
@jpogran jpogran added enhancement New feature or request and removed dependencies Pull requests that update a dependency file labels Apr 4, 2022
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck Awaiting requested review from dbanck

Assignees

@jpogran jpogran

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Action fails behind the proxy
3 participants
@rabun788 @hashicorp-cla @jpogran