Handle installSnapshot decodePeers error without a panic #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banks
approved these changes
May 4, 2021
decodePeers can be called by the installSnapshot RPC handler, which means that a panic could be caused by an external actor by sending malformed input. Instead handle the error and report it back via the RPC response.
dnephin
force-pushed
the
dnephin/fix-panic-in-decodePeers
branch
from
5eed31b to
e59f65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodePeerscan be called by theinstallSnapshotRPC handler, which means that a panic can be caused by an external actor by sending malformed input. Instead handle the error and report it back via the RPC response. This prevents a panic and removes the possibility of an external actor being able to cause a raft peer to panic.The new test would cause a panic before, and now it confirms the expected error is returned.