refactor: remove deprecated InitializePluginVersion, replace with NewPluginVersion #13016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lbajolet-hashicorp
added
the
tech-debt
lbajolet-hashicorp
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Hey @IAMDAVID0920,
Thanks for picking these up, forgot to update them when we bumped the SDK.
LGTM, will merge once tests go green!
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is just a minor refactor based on the awesome work here: hashicorp/packer-plugin-sdk#228
Replace all the
InitializePluginVersionwithNewPluginVersionin the packer code base.Reason:
We've decided to deprecate
InitializePluginVersion, so it is time for us to switch toNewPluginVersionwhich now supportsVersionMetadatafor plugin developers, and this can also be a seamless transition once we fully dropInitializePluginVersionin the future.