-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Azure plugin components from Packer #10979
Conversation
nywilken
commented
Apr 26, 2021
•
edited
Loading
edited
- Remove Azure components and docs
- Vendor remote plugin
- Add remote docs
- Migrate issues to new repo
- Cherry pick onto stable website
Can you prioritize this? It makes me nervous having the plugin in two places, especially now that we've cut a release on the external azure plugin. |
@SwampDragons this is ready for review. The cherry pick onto stable website is for the docs once merged. Sorry for any confusion. I saw that the release was made so I did the vendoring and added the docs to complete the change. Do let me know if you think something is missing. Thanks! |
Hmmm...looks like my last build ended in a panic. Adding to the top of my list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...looks like my last build ended in a panic. Adding to the top of my list
Couldn't find which build panicked 🤔 This LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one, LGTM
* Updates Azure to use remote plugin docs
* Update to new version of the Packer plugin SDK v0.2.1 * Update to the official version of go-getter@v2.0.0 * Update salt provisioner to use new go-getter API
This changes fixes an issue with the go.sum for the Azure plugin. It also revendors the plugins for puppet, chef, and ansible as v0.0.1 of those plugins where not usable.
Confirmed to be executing as expected using the vendored plugin
|
🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |