Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Azure plugin components from Packer #10979

Merged
merged 4 commits into from
May 13, 2021
Merged

Extract Azure plugin components from Packer #10979

merged 4 commits into from
May 13, 2021

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Apr 26, 2021

  • Remove Azure components and docs
  • Vendor remote plugin
  • Add remote docs
  • Migrate issues to new repo
  • Cherry pick onto stable website

@nywilken nywilken requested review from paulmey and a team as code owners April 26, 2021 20:27
@nywilken nywilken changed the title [WIP] Extract Azure plugin components from Packer Extract Azure plugin components from Packer May 11, 2021
@SwampDragons
Copy link
Contributor

Can you prioritize this? It makes me nervous having the plugin in two places, especially now that we've cut a release on the external azure plugin.

@nywilken
Copy link
Contributor Author

nywilken commented May 11, 2021

Can you prioritize this? It makes me nervous having the plugin in two places, especially now that we've cut a release on the external azure plugin.

@SwampDragons this is ready for review. The cherry pick onto stable website is for the docs once merged. Sorry for any confusion. I saw that the release was made so I did the vendoring and added the docs to complete the change. Do let me know if you think something is missing. Thanks!

@nywilken
Copy link
Contributor Author

Can you prioritize this? It makes me nervous having the plugin in two places, especially now that we've cut a release on the external azure plugin.

@SwampDragons this is ready for review. The cherry pick onto stable website is for the docs once merged. Sorry for any confusion. I saw that the release was made so I did the vendoring and added the docs to complete the change. Do let me know if you think something is missing. Thanks!

Hmmm...looks like my last build ended in a panic. Adding to the top of my list

Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...looks like my last build ended in a panic. Adding to the top of my list

Couldn't find which build panicked 🤔 This LGTM 👍🏼

Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, LGTM

* Update to new version of the Packer plugin SDK v0.2.1
* Update to the official version of go-getter@v2.0.0
* Update salt provisioner to use new go-getter API
This changes fixes an issue with the go.sum for the Azure plugin.
It also revendors the plugins for puppet, chef, and ansible as v0.0.1
of those plugins where not usable.
@nywilken
Copy link
Contributor Author

Confirmed to be executing as expected using the vendored plugin


~>  PACKER_ACC=1 AZURE_CLI_AUTH=1 go test -count 1 -v ./builder/azure/arm/... -run='TestBuilderAcc_.*_Linux' --timeout=120m
=== RUN   TestBuilderAcc_ManagedDisk_Linux
--- PASS: TestBuilderAcc_ManagedDisk_Linux (437.47s)
=== RUN   TestBuilderAcc_ManagedDisk_Linux_DeviceLogin
    builder_acc_test.go:128: Device Login Acceptance tests skipped unless env 'DEVICELOGIN_TEST' set, as its requires manual step during execution
--- SKIP: TestBuilderAcc_ManagedDisk_Linux_DeviceLogin (0.00s)
=== RUN   TestBuilderAcc_ManagedDisk_Linux_AzureCLI
--- PASS: TestBuilderAcc_ManagedDisk_Linux_AzureCLI (430.41s)
=== RUN   TestBuilderAcc_Blob_Linux
--- PASS: TestBuilderAcc_Blob_Linux (298.26s)
PASS
ok      github.com/hashicorp/packer-plugin-azure/builder/azure/arm      1166.514s

~>  PACKER_ACC=1 AZURE_CLI_AUTH=1 go test -count 1 -v ./builder/azure/arm/... -run='TestBuilderAcc_.*_Windows' --timeout=120m
=== RUN   TestBuilderAcc_ManagedDisk_Windows
--- PASS: TestBuilderAcc_ManagedDisk_Windows (457.46s)
=== RUN   TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group
--- PASS: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group (517.58s)
=== RUN   TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk
--- PASS: TestBuilderAcc_ManagedDisk_Windows_Build_Resource_Group_Additional_Disk (470.55s)
=== RUN   TestBuilderAcc_ManagedDisk_Windows_DeviceLogin
    builder_acc_test.go:90: Device Login Acceptance tests skipped unless env 'DEVICELOGIN_TEST' set, as its requires manual step during execution
--- SKIP: TestBuilderAcc_ManagedDisk_Windows_DeviceLogin (0.00s)
=== RUN   TestBuilderAcc_Blob_Windows
--- PASS: TestBuilderAcc_Blob_Windows (603.61s)
PASS
ok      github.com/hashicorp/packer-plugin-azure/builder/azure/arm      2050.231s

@nywilken nywilken merged commit c262467 into master May 13, 2021
@nywilken nywilken deleted the extract-azure branch May 13, 2021 20:13
@SwampDragons
Copy link
Contributor

🎉

@SwampDragons SwampDragons added this to the 1.7.3 milestone May 19, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants