Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HPR-1108] Replace gitub.com/zclconf/go-cty@1.12.1 with fork github.com/nywilken/go-cty #189

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

nywilken
Copy link
Member

@nywilken nywilken commented Jun 20, 2023

In an effort to provide Packer plugins access to the github.com/zclconf/go-cty enhancements, while still providing access to encoding/gob support the Packer team has forked the go-cty package under github.com/nywilken/go-cty.
This is a temporary fork that will be removed once it is no longer needed.

  • This change also reverts the Go statement to 1.18 in the go.mod file. The SDK has no dependencies on Go 1.20 to justify the Go version bump in the module file.

Relates to: #187

…/go-cty

In an effort to provide Packer plugins access to the github.com/zclconf/go-cty enhancements,
while still providing access to encoding/gob support the Packer team has forked the go-cty package under github.com/nywilken/go-cty.
This is a temporary fork that will be removed once it is no longer needed.

Refer to #187
@nywilken nywilken requested a review from a team as a code owner June 20, 2023 18:40
@nywilken nywilken changed the title Replace gitub.com/zclconf/go-cty@1.12.1 with fork github.com/nywilken/go-cty [HPR-1108] Replace gitub.com/zclconf/go-cty@1.12.1 with fork github.com/nywilken/go-cty Jun 20, 2023
nywilken and others added 3 commits June 21, 2023 21:02
This commit updates github.com/hashicorp/hcl/v2 to the last known release of HCL/v2
that does not rely on v1.13.0 of github.com/zclconf/go-cty.
```
~> go fix ./...
filelock/filelock.go: fixed buildtag
multistep/commonsteps/iso_config_test.go: fixed buildtag
packer/cache_config_unix.go: fixed buildtag
packer/cache_config_unix_test.go: fixed buildtag
packer/cache_config_windows.go: fixed buildtag
packer/cache_config_windows_test.go: fixed buildtag
pathing/config_file_unix.go: fixed buildtag
pathing/config_file_unix_test.go: fixed buildtag
pathing/config_file_windows.go: fixed buildtag
pathing/config_file_windows_test.go: fixed buildtag
sdk-internals/communicator/ssh/communicator_test.go: fixed buildtag
template/parse_test.go: fixed buildtag

```
@nywilken nywilken marked this pull request as draft June 22, 2023 23:28
@nywilken nywilken marked this pull request as ready for review June 22, 2023 23:28
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough to review, I like that :)
LGTM!

@nywilken nywilken added bug Something isn't working dependencies Pull requests that update a dependency file labels Jul 5, 2023
@nywilken nywilken merged commit af18c71 into main Jul 5, 2023
5 checks passed
@nywilken nywilken deleted the nywilken/go-cty-fork branch July 5, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants