Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some more typos. #445

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Fixed some more typos. #445

merged 5 commits into from
Oct 29, 2024

Conversation

lzandman
Copy link
Contributor

@lzandman lzandman commented Oct 3, 2024

I again fixed some typos. As in #391 I wasn't able to test make generate on my current system. I did not alter any files from .web-docs, so I hope the pipeline validation will succeed.

@lzandman lzandman requested a review from a team as a code owner October 3, 2024 15:28
@lzandman
Copy link
Contributor Author

lzandman commented Oct 3, 2024

I guess I'm still doing something wrong...

Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

Can you address the two comments I've made, afterwards I can run make generate for you if it still does not work on your system.

Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran go fmt ./... to fix the last failing actions check on this PR and then pushed it to your fork, this looks good to me, thank you for this contribution @lzandman!

@JenGoldstrich JenGoldstrich merged commit 3308e28 into hashicorp:main Oct 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants