Use pollingContext for data disk snapshot #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lbajolet-hashicorp
approved these changes
May 24, 2024
There was a problem hiding this comment.
Hey @dreweasland,
Good catch and thanks for the fix, from a quick glance this looks good to me, thanks for confirming this fixes the problem in your case.
I'll let @JenGoldstrich review and merge this since she's our expert/maintainer for this plugin, but this looks good to me, approving in advance.
|
Hey @dreweasland Good catch and thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to the latest SDK, it appears that the polling context isn't utilized during data disk snapshot creation. This was causing the following error when a data disk snapshot was requested:
the context used must have a deadline attached for polling purposes, but got no deadlineI've updated the Get call to utilize
pollingContext.Built the plugin from my forked branch and ran it and it was able to finish successfully