Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v2.1.0 regression when using custom_managed_image_name source #402

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

JenGoldstrich
Copy link
Contributor

@JenGoldstrich JenGoldstrich commented Apr 10, 2024

On v2.1.0 we switched to using go-azure-sdk base layer clients, which require a polling context, we missed one of those and there isn't a case for this in our acceptance testing currently so this was missed.

Before this change when building using a custom_managed_image_name source

azure-arm.autogenerated_1: output will be in this color.

==> azure-arm.autogenerated_1: Running builder ...
    azure-arm.autogenerated_1: Creating Azure Resource Manager (ARM) client ...
    azure-arm.autogenerated_1: ARM Client successfully created
Build 'azure-arm.autogenerated_1' errored after 957 milliseconds 28 microseconds: loading results: the context used must have a deadline attached for polling purposes, but got no deadline

==> Wait completed after 957 milliseconds 237 microseconds

==> Some builds didn't complete successfully and had errors:
--> azure-arm.autogenerated_1: loading results: the context used must have a deadline attached for polling purposes, but got no deadline

==> Builds finished but no artifacts were created.

After this change the build succeeds

Closes #401

@JenGoldstrich JenGoldstrich requested a review from a team as a code owner April 10, 2024 17:09
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JenGoldstrich JenGoldstrich merged commit daa52fb into main Apr 10, 2024
12 checks passed
@JenGoldstrich JenGoldstrich deleted the custom_managed_image_polling_error branch April 10, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packer Azure Plugin (2.1.0) fails immediately with "...context used must have a deadline attached...".
2 participants