Update to the newest version of hashicorp/go-azure-sdk #396
Conversation
JenGoldstrich
changed the title
JenGoldstrich
force-pushed
the
bump_go_azure_sdk
branch
3 times, most recently
from
cfe7219 to
5e0089e
Compare
| @@ -50,12 +45,18 @@ type AzureClientSet interface { | |||
| var _ AzureClientSet = &azureClientSet{} | |||
|
|
|||
| type azureClientSet struct { | |||
There was a problem hiding this comment.
While this client is in the common package it is only used by the chroot builder, the way I made this work with the new clients is a bit hacky, but I felt it wasn't worth a lot of time refactoring the chroot builder heavily as it makes up a very small percent of our usage.
JenGoldstrich
force-pushed
the
bump_go_azure_sdk
branch
2 times, most recently
from
ea49404 to
4e24ebf
Compare
| @@ -1,40 +1,36 @@ | |||
| module github.com/hashicorp/packer-plugin-azure | |||
|
|
|||
| go 1.19 | |||
| go 1.21 | |||
There was a problem hiding this comment.
packer-plugin-azure/.go-version
Line 1 in 36cc195
There was a problem hiding this comment.
Is 1.21.8 a requirement for these changes or should we just always set to 1.21.N since this is technically the latest version?
There was a problem hiding this comment.
Not at all, I just bumped us to 1.21 based on what was already set in the .go-version, these changes should work independent of go minor version.
JenGoldstrich
force-pushed
the
bump_go_azure_sdk
branch
2 times, most recently
from
06081ef to
47c605c
Compare
GNUmakefile
Outdated
| dev: build | ||
| @mkdir -p ~/.packer.d/plugins/ | ||
| @mv ${BINARY} ~/.packer.d/plugins/${BINARY} | ||
| dev: |
There was a problem hiding this comment.
I'm not sure why this is showing up as a change, when I checkout the makefile from main I don't see any changes either 🤔
➜ packer-plugin-azure git:(bump_go_azure_sdk) git checkout origin/main -- GNUmakefile
➜ packer-plugin-azure git:(bump_go_azure_sdk) gst
On branch bump_go_azure_sdk
nothing to commit, working tree clean
…ug, move metadata client off auto-rest, and handle unathenticated subscription call in custom http client
JenGoldstrich
force-pushed
the
bump_go_azure_sdk
branch
from
7d494b0 to
21eb7b2
Compare
This PR makes several changes to upgrade
github.com/hashicorp/go-azure-sdkfrom versionv0.20230523.1140858to the newest version at the time of this PRv0.20240327.1161949, and to fully remove the deprecated Microsoftgo-autorestlibrary.Every request on the new SDK client layer requires a context with a deadline, otherwise requests fail with the following error
the context used must have a deadline attached for polling purposes, but got no deadline, even if counter-intuitively the request would not use pollingWhen the tenant ID is unset and not using CLI auth the plugin makes an unauthenticated HTTP request to the GetSubscriptions endpoint to fetch the tenant ID through the auth headers, the new SDK does not return these headers unless the auth object is correctly configured so now this is done with a regular http client
The Chroot Builder used an autorest client to connect to the Azure IMDS, this has also been modified to use a regular http client, enabling the removal of auto rest
The chroot builder has a long running bug Azure-chroot has issues with detecting environment information. Error is 'function "vm" not defined' #87 where we get an error that the
vmtemplate function is not defined unless setting 4 temporary values, this is due to an issue with the packer SDK wiping out this function when calling Decode, @lbajolet-hashicorp is investigating this issue further on the SDK end but to fix this on chroot this PR moves the function after Decode, so that is available in the builder. Thevmfunction does not appear to be working at all currently, but this seems due to the SDK bug, and will be addressed in a follow up PR if not.Closes #87
Unblocks #395