Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNUmakefile: make dev uses packer for install #390

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

lbajolet-hashicorp
Copy link
Contributor

When building the development version of the plugin, we now use
packer plugins install for that instead of moving it to the plugins
directory manually.

This target will require Packer 1.10.2 and above to function, as prior
versions don't support instaling pre-release versions of a plugin with
that command.

@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner March 14, 2024 15:34
When building the development version of the plugin, we now use
`packer plugins install` for that instead of moving it to the plugins
directory manually.

This target will require Packer 1.10.2 and above to function, as prior
versions don't support instaling pre-release versions of a plugin with
that command.
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the makefile_dev_use_packer_install branch from a633a27 to 42d4559 Compare March 19, 2024 15:17
Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JenGoldstrich JenGoldstrich merged commit d34883b into main Mar 26, 2024
12 checks passed
@JenGoldstrich JenGoldstrich deleted the makefile_dev_use_packer_install branch March 26, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants