Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in replicated_regions attribute #379

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Feb 22, 2024

When implementing the target_region attribute for the Shared Image
Gallery Destination a regression introduced with replication_regions, where an empty Disk
encryption key was being sent along with the request. Ultimately
causing the image capture to fail with an invalid DES key error.

Related to: #264

When implementing the target_region attribute for the Shared Image
Gallery Destination a regression introduced with replication_regions, where an empty Disk
encryption key was being sent along with the request. Ultimately
causing the image capture to fail with an invalid DES key error.
@nywilken nywilken requested a review from a team as a code owner February 22, 2024 15:23
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 🎉

@nywilken nywilken merged commit 8666fcc into main Feb 22, 2024
12 checks passed
@nywilken nywilken deleted the nywilken/fix-target-region-DES-bug branch February 22, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants