client: propagate ClientID to MSI auth #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manages System Identity authentication methods support using a ClientID, but wasn't propagated to the SDK. This causes issues for users that had more than one identity managed by the endpoint, as the authenticator would default to using the system-assigned identity, which may not have the permissions required to perform the build. Since this is already supported by the SDK used by the plugin, we forward this information (already available as part of the configuration for the builders) to the SDK so it gets the requested user-assigned identity token from the authentication endpoint.
JenGoldstrich
approved these changes
Dec 21, 2023
|
All checked here!! Thank you and you're welcome😉❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manages System Identity authentication methods support using a ClientID, but wasn't propagated to the SDK.
This causes issues for users that had more than one identity managed by the endpoint, as the authenticator would default to using the system-assigned identity, which may not have the permissions required to perform the build.
Since this is already supported by the SDK used by the plugin, we forward this information (already available as part of the configuration for the builders) to the SDK so it gets the requested user-assigned identity token from the authentication endpoint.
Closes #353