Acceptance Test Overhaul: Manage resources for tests in Terraform and run them on pushes to main #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenGoldstrich
force-pushed
the
acceptance-tests-terraform
branch
4 times, most recently
from
594d113 to
2e9a019
Compare
JenGoldstrich
changed the title
JenGoldstrich
force-pushed
the
acceptance-tests-terraform
branch
from
0879444 to
0ff2d25
Compare
WIP Forgot DTL resources Update Terraform Commit workflow for testing Forgot to add service principal flag Set variable for azure cli auth, auto approve terraform destroy Use always instead of continue-on-error, and upload logs Update acceptance-tests.yaml Update acceptance-tests.yaml Use variables thruout to control resource group and storage account names Fix failing json conversions, refactor env variable checking to shared file
… OIDC Test as it no longer works in new subscription, update comments
JenGoldstrich
force-pushed
the
acceptance-tests-terraform
branch
from
0ff2d25 to
329b601
Compare
JenGoldstrich
changed the title
lbajolet-hashicorp
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Good job here @JenGoldstrich, this looks cool, I like that we're simplifying running those tests.
I left some suggestions on some changes, feel free to accept or reject those.
LGTM!
Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>
Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>
… out of date device code auth comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to enable the acceptance tests for the plugin to run on pushes to main in CI.
./terraformwhich manage the creation of several Azure resources the tests need to passaz account showto make sure Azure CLI auth is set up.Potential follow up work will be to add support for variable files to the packer-plugin-sdk acceptance test module, so that we can better manage resource group name and storage account, and start managing dtl lab name, and gallery name, so that these tests can be run by multiple sessions in the same Subscription