-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration plugin docs to integration framework #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -35,3 +35,8 @@ generate: install-packer-sdc | |||
packer-sdc renderdocs -src ./docs -dst ./.docs -partials ./docs-partials | |||
# checkout the .docs folder for a preview of the docs | |||
|
|||
build-docs: install-packer-sdc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still leave the older generate task in place, should we only use build-docs after this PR is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're referring to the release pipeline. We are keeping everything the same until we've cut over the plugins to production. Once live we can remove the doc.zip generation. But it should not affect anything if left in place.
docs/README.md
Outdated
source = "github.com/hashicorp/azure" | ||
version = "~> 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that v2 is out, we could update this block to point to this version I would think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Add scaffolding for HashiCorp integrations