Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run commands for duration and interval without needing to specify server or node #8793

Merged
merged 1 commit into from
Aug 31, 2020
Merged

run commands for duration and interval without needing to specify server or node #8793

merged 1 commit into from
Aug 31, 2020

Conversation

drewbailey
Copy link
Contributor

@drewbailey drewbailey commented Aug 31, 2020 •
edited
Loading

I wasn't sure why a set of Nodes or servers were required to run on interval or duration, so removing those checks

This allows to just run nomad operator debug -interval=5s -duration=10s -output=test with default api address settings

langmartin
langmartin approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@langmartin langmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and was just an oversight due to late design decisions.

@drewbailey drewbailey merged commit 2740b48 into master Aug 31, 2020
@drewbailey drewbailey deleted the debug-cli/run-intervals branch August 31, 2020 20:07
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@langmartin langmartin langmartin approved these changes

@notnoop notnoop Awaiting requested review from notnoop

@davemay99 davemay99 Awaiting requested review from davemay99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewbailey @langmartin