variables: fix access to variables for poststop tasks #19270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the recent auth refactor, we accidentally fixed a bug where poststop tasks would not get access to Variables. Fix this same bug for backports by ensuring that we use client-terminal status and not server-terminal status to enforce access.
tgross
force-pushed
the
b-nomad-claim-for-poststop
branch
from
aa322d2
to
2ae7099
Compare
lgfa29
approved these changes
Dec 1, 2023
tgross
added a commit
that referenced
this pull request
Dec 1, 2023
In the recent auth refactor, we accidentally fixed a bug where poststop tasks would not get access to Variables. Fix this same bug for backports by ensuring that we use client-terminal status and not server-terminal status to enforce access.
|
Backported to 1.5.x as well. |
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
…corp#19275) In hashicorp#18754 we accidentally fixed a bug that prevented poststop tasks from getting access to Variables. This was fixed in the 1.6.x branch in hashicorp#19270, at which point we discovered the fix had been done in main already as part of the auth refactor. Add a changelog entry for it.
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
…corp#19275) In hashicorp#18754 we accidentally fixed a bug that prevented poststop tasks from getting access to Variables. This was fixed in the 1.6.x branch in hashicorp#19270, at which point we discovered the fix had been done in main already as part of the auth refactor. Add a changelog entry for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent auth refactor, we accidentally fixed a bug where poststop tasks would not get access to Variables. Fix this same bug for backports by ensuring that we use client-terminal status and not server-terminal status to enforce access.
Note this is a backport-only PR.
Ref: #16886