Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: split consul config params into client vs server sections #19258

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

tgross
Copy link
Member

@tgross tgross commented Dec 1, 2023

Some sections of the consul configuration are relevant only for clients or servers. We updated our Vault docs to split these parameters out into their own sections for clarity. Match that for the Consul docs.

Preview link: https://nomad-amgfwjney-hashicorp.vercel.app/nomad/docs/configuration/consul

Some sections of the `consul` configuration are relevant only for clients or
servers. We updated our Vault docs to split these parameters out into their own
sections for clarity. Match that for the Consul docs.
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes it much clearer!

@tgross tgross merged commit 2ba459c into main Dec 1, 2023
7 checks passed
@tgross tgross deleted the docs-consul-config-split-client-server branch December 1, 2023 18:37
nvanthao pushed a commit to nvanthao/nomad that referenced this pull request Mar 1, 2024
…shicorp#19258)

Some sections of the `consul` configuration are relevant only for clients or
servers. We updated our Vault docs to split these parameters out into their own
sections for clarity. Match that for the Consul docs.
nvanthao pushed a commit to nvanthao/nomad that referenced this pull request Mar 1, 2024
…shicorp#19258)

Some sections of the `consul` configuration are relevant only for clients or
servers. We updated our Vault docs to split these parameters out into their own
sections for clarity. Match that for the Consul docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.7.x backport to 1.7.x release line theme/consul theme/docs Documentation issues and enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants