identity: version check multiple and implicit identities #18926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job submitters cannot set multiple identities prior to Nomad 1.7, and cluster administrators should not set the identity configurations for their `consul` and `vault` configuration blocks until all servers have been upgraded. Validate these cases during job submission so as to prevent state store corruption when jobs are submitting in the middle of a cluster upgrade.
tgross
force-pushed
the
identitites-min-version-check
branch
from
7d1bddd
to
8b4ed26
Compare
schmichael
approved these changes
Oct 31, 2023
Comment on lines
+413
to
+417
| if v.srv == nil || v.srv.serf == nil { | ||
| return true // handle tests w/o real servers safely | ||
| } | ||
| return ServersMeetMinimumVersion( | ||
| v.srv.Members(), v.srv.Region(), minVersionMultiIdentities, true) |
There was a problem hiding this comment.
Would be nice if ServersMeetMinimumVersion was a struct that wrapped up Members() and Region() and only provided a simple Meets(version, checkFailed) interface for us to mock/stub out in tests.
nbd though, nothing to block this work on.
There was a problem hiding this comment.
I've opened #18931 to follow-up on that when I have a few minutes.
tgross
force-pushed
the
identitites-min-version-check
branch
from
67502f6
to
91be7e3
Compare
tgross
force-pushed
the
identitites-min-version-check
branch
from
91be7e3
to
486b2b9
Compare
Agreed. I'll follow-up with that in a separate PR. |
|
Follow-up for the client version check in #18932 |
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
…8926) Job submitters cannot set multiple identities prior to Nomad 1.7, and cluster administrators should not set the identity configurations for their `consul` and `vault` configuration blocks until all servers have been upgraded. Validate these cases during job submission so as to prevent state store corruption when jobs are submitting in the middle of a cluster upgrade.
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
…8926) Job submitters cannot set multiple identities prior to Nomad 1.7, and cluster administrators should not set the identity configurations for their `consul` and `vault` configuration blocks until all servers have been upgraded. Validate these cases during job submission so as to prevent state store corruption when jobs are submitting in the middle of a cluster upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job submitters cannot set multiple identities prior to Nomad 1.7, and cluster administrators should not set the identity configurations for their
consulandvaultconfiguration blocks until all servers have been upgraded. Validate these cases during job submission so as to prevent state store corruption when jobs are submitting in the middle of a cluster upgrade.