Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: actor based state handling, streaming container stats and podman events #80

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

towe75
Copy link
Collaborator

@towe75 towe75 commented Jan 3, 2021

Goals of this branch:

  • avoid mutexes for taskhandle storage
  • replace per-task container stats polling with a single stats stream
  • replace per-task container dead check with a podman event stream observer
  • fix a long standing race condition with very short living containers

General idea is to replace the mutex based task store with a message based actor. The actors mailbox, a simple channel, serializes all requests and makes explicit locking unnecessary in a lot of cases.

It's expected that these changes greatly improve the performance of this plugin.

One bug that i found while working on the branch: containers/podman#8864

Base automatically changed from master to main March 3, 2021 20:39
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@apollo13
Copy link
Contributor

Hi @towe75, this looks great. What would be needed to move this forward? Also I See that you are restarting the stats/event streams after some delay if the fail. Wouldn't that mean that we loose events?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants