Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Image registry authentication #71 #112

Merged
merged 4 commits into from
May 19, 2021
Merged

config: Image registry authentication #71 #112

merged 4 commits into from
May 19, 2021

Conversation

towe75
Copy link
Collaborator

@towe75 towe75 commented May 16, 2021

This addresses #71
It adds a auth {username, password} task configuration option.

@towe75 towe75 requested a review from drewbailey May 16, 2021 17:55
drewbailey
drewbailey reviewed May 17, 2021
View reviewed changes
drewbailey
drewbailey reviewed May 17, 2021
View reviewed changes
drewbailey
drewbailey reviewed May 17, 2021
View reviewed changes
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think we just want to only set the request header values if ImageAuthConfig is actually set

towe75 and others added 2 commits May 19, 2021 20:07
@towe75 @drewbailey
Spelling
860022b 
Co-authored-by: Drew Bailey <drewbailey5@gmail.com>
@towe75
Add auth header only if we have username and password
68785fd
@towe75 towe75 requested a review from drewbailey May 19, 2021 19:01
drewbailey
drewbailey approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@towe75 towe75 merged commit 48e97ca into main May 19, 2021
@towe75 towe75 deleted the f_auth branch May 19, 2021 19:05
@towe75 towe75 mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbailey drewbailey drewbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@towe75 @drewbailey