Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run CI on pull requests #947

Merged
merged 1 commit into from
Aug 8, 2024
Merged

test: run CI on pull requests #947

merged 1 commit into from
Aug 8, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Aug 8, 2024

The GitHub Actions configuration doesn't run CI on pull requests, only on pushes which doesn't cover external PRs (Ex #945). Update the behavior to match what we do in Nomad core, where PRs get CI as well as merges to main.

The GitHub Actions configuration doesn't run CI on pull requests, only on
pushes which doesn't cover a PR with a single push. Update the behavior to match
what we do in Nomad core, where PRs get CI as well as merges to main.
@tgross tgross requested review from a team, jrasell and Juanadelacuesta as code owners August 8, 2024 14:19
Copy link
Contributor

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tgross tgross merged commit d15da50 into main Aug 8, 2024
33 checks passed
@tgross tgross deleted the ci-tests branch August 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants