Add TypeScript definition file #75
Conversation
|
|
|
This is amazing, thank you @stevenschmatz ! |
|
Hi! Great work. What's the ETA on this? |
|
I have to pull it down and test it pretty thoroughly locally, it will either be today or tomorrow or after the holiday break! |
| * For example: `{ ComponentName: Component }` will be accessible in the MDX as `<ComponentName/>`. | ||
| */ | ||
| components?: { | ||
| [componentName: string]: React.FunctionComponent | React.Component; |
There was a problem hiding this comment.
When I was working on type definitions, I also found that I needed to specify this type in this way instead of just React.Element, but was confused about why. Do you have any further insight on this one?
|
Ok, I pulled this down and ran it through some tests. It's a great start but needed a lot of work to get through mildly strict typescript settings. I ended up updating my own PR with additional typings - could you give that a look and let me know what you think? |
|
Closing in favor of #70 - thank you for the contribution though! 💖 |
Hey there! First, thank you for maintaining this great library. I wanted to contribute some types and documentation to make this library easier to use for TypeScript folks.
Side note: I saw that there was another PR for adding a definition file, not sure if you want me to commit some of this over there or not. Thanks!