Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove newline from template literal #346

Merged
merged 2 commits into from
Feb 27, 2023
Merged

remove newline from template literal #346

merged 2 commits into from
Feb 27, 2023

Conversation

chrisweb
Copy link
Contributor

fixes #345

I removed the newline from the template literal used to demonstrate the new rsc example with frontmatter to fix frontmatter not getting parsed, so now it is the same as the example that is given in the advanced example "Parsing Frontmatter"

I also removed the newline from all the other examples, because if someone uses one of those and then adds frontmatter to his code he will end having the problem, so to avoid that I thought it is better to just change them all, but maybe this is not what you want in which case I can change it or you undo it

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 27, 2023

CLA assistant check
All committers have signed the CLA.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BRKalow BRKalow merged commit 697c682 into hashicorp:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parseFrontmatter option doesn't work with next-mdx-remote/rsc
4 participants