Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix an issue when the Module cannot get Workspace by ID #77

Merged
merged 2 commits into from
Jan 31, 2023
Merged

🐛 Fix an issue when the Module cannot get Workspace by ID #77

merged 2 commits into from
Jan 31, 2023

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Jan 31, 2023 •
edited
Loading

Description

This PR fixes an issue when the Module CR fails if it refers to Workspace by ID and updates tests to catch this scenario.

Usage Example

N/A.

Release Note

Release note for CHANGELOG:

`Module`: Fix an issue when the Module CR fails if it refers to Workspace by ID.

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@arybolovlev arybolovlev marked this pull request as ready for review January 31, 2023 15:05
@arybolovlev arybolovlev requested a review from a team as a code owner January 31, 2023 15:05
@arybolovlev arybolovlev merged commit 4791d86 into main Jan 31, 2023
@arybolovlev arybolovlev deleted the fix-module-ref-by-id branch January 31, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
controller golang size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arybolovlev