Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Update Workspace controller default project ID reconciliation logic #481

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Aug 30, 2024

Description

Update the default project ID reconciliation logic in the Workspace controller to avoid making an API call each time a workspace object is updated. Since the default project ID is immutable, we can get it and keep in status.defaultProjectID for future usage.

Tests

  • E2E on HCP Terraform Operator
  • E2E on HCP Terraform Operator [Helm]
  • E2E on Terraform Enterprise
  • E2E on Terraform Enterprise [Helm]

Usage Example

A new field defaultProjectID has been added to Status:

status:
  defaultProjectID: prj-vakhExdgszGgcNfZ

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

…ault project ID on every reconciliation when workspace gets updated
@arybolovlev arybolovlev marked this pull request as ready for review August 30, 2024 07:50
@arybolovlev arybolovlev requested a review from a team as a code owner August 30, 2024 07:50
@arybolovlev arybolovlev merged commit 601ef7d into main Sep 25, 2024
7 checks passed
@arybolovlev arybolovlev deleted the update-workspace-default-project branch September 25, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants