Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Update Workspace SSH key reconciliation logic #478

Merged
merged 11 commits into from
Oct 21, 2024
Merged

🚀 Update Workspace SSH key reconciliation logic #478

merged 11 commits into from
Oct 21, 2024

Conversation

arybolovlev
Copy link
Contributor

Description

This PR updates Workspace SSH key reconciliation logic to reduce the number of API calls.

Tests

  • E2E on HCP Terraform Operator
  • E2E on HCP Terraform Operator [Helm]
  • E2E on Terraform Enterprise
  • E2E on Terraform Enterprise [Helm]

Usage Example

N/A.

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@arybolovlev arybolovlev marked this pull request as ready for review August 22, 2024 12:53
@arybolovlev arybolovlev requested a review from a team as a code owner August 22, 2024 12:53
alexsomesan
alexsomesan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Dropped a small suggestion, but we discussed it in Slack.

@arybolovlev arybolovlev merged commit 8b93f08 into main Oct 21, 2024
11 checks passed
@arybolovlev arybolovlev deleted the update-ssh-key-reconciliation branch October 21, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
api controller crd golang helm-chart size/L test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arybolovlev @alexsomesan