Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Update predicates #343

Merged
merged 2 commits into from
Feb 26, 2024
Merged

🛠️ Update predicates #343

merged 2 commits into from
Feb 26, 2024

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Feb 23, 2024 •
edited
Loading

Description

This PR adds the ability to add per-controller predicates in addition to the generic predicates that apply to all controllers.

Usage Example

N/A.

References

N/A.

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@github-actions github-actions bot added controller documentation Improvements or additions to documentation golang size/XS labels Feb 23, 2024
@arybolovlev arybolovlev marked this pull request as ready for review February 23, 2024 18:57
@arybolovlev arybolovlev requested a review from a team as a code owner February 23, 2024 18:57
@arybolovlev arybolovlev removed the documentation Improvements or additions to documentation label Feb 23, 2024
sheneska
sheneska approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@sheneska sheneska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arybolovlev arybolovlev merged commit cfff91f into main Feb 26, 2024
6 checks passed
@arybolovlev arybolovlev deleted the update-predicates branch February 26, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

@sheneska sheneska sheneska approved these changes

Assignees
No one assigned
Labels
controller golang pr/no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arybolovlev @alexsomesan @sheneska