Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add the ability to configure kube-rbac-proxy resources #259

Merged
merged 2 commits into from
Oct 11, 2023
Merged

🚀 Add the ability to configure kube-rbac-proxy resources #259

merged 2 commits into from
Oct 11, 2023

Conversation

kieranbrown
Copy link
Contributor

Description

This PR adds the ability to configure kube-rbac-proxy resource requests/limits. Typically I prefer to not set CPU limits as recommended by https://twitter.com/thockin/status/1134193838841401345, which currently isn't possible to achieve.

Usage Example

kubeRbacProxy:
  resources:
    limits:
      cpu: null
      memory: 128Mi
    requests:
      cpu: 50m
      memory: 128Mi

Release Note

Release note for CHANGELOG:

Add the ability to configure kube-rbac-proxy resources

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@kieranbrown kieranbrown requested a review from a team as a code owner September 6, 2023 11:07
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart size/XS labels Sep 6, 2023
Copy link
Contributor

@arybolovlev arybolovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kieranbrown,

Thanks for spotting and fixing it!

@arybolovlev arybolovlev merged commit 63ce7af into hashicorp:main Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants