Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some better naming for autoscaler functions #220

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Some better naming for autoscaler functions #220

merged 1 commit into from
Jul 18, 2023

Conversation

jrhouston
Copy link
Contributor

@jrhouston jrhouston commented Jul 17, 2023 •
edited
Loading

Description

Changes pendingRuns to queueDepth since we are not just looking at the pending status.

Usage Example

Release Note

Release note for CHANGELOG:

NONE

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@jrhouston jrhouston requested a review from a team as a code owner July 17, 2023 20:06
@jrhouston jrhouston changed the title some better naming for autoscaler functions Some better naming for autoscaler functions Jul 17, 2023
@jrhouston jrhouston merged commit 125a544 into main Jul 18, 2023
8 checks passed
@jrhouston jrhouston deleted the autoscaler-refactor-naming branch July 18, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybolovlev arybolovlev arybolovlev approved these changes

Assignees
No one assigned
Labels
controller golang size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrhouston @arybolovlev