fs.AnyVersion: Introduce ExactBinPath #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-exact-bin-path
branch
from
fd3d746
to
43d4644
Compare
Co-authored-by: Brian Flad <bflad417@gmail.com>
bflad
reviewed
Nov 30, 2021
| if av.ExactBinPath != "" && (av.Product != nil || len(av.ExtraPaths) > 0) { | ||
| return fmt.Errorf("use either ExactBinPath or Product + ExtraPaths, not both") | ||
| } | ||
| if !filepath.IsAbs(av.ExactBinPath) { |
There was a problem hiding this comment.
Should this have a av.ExactBinPath != "" check prior to checking for the absolute file path? Sorry thought the testing would've caught this, but for some reason getting this error when implementing v0.3.0 downstream:
=== RUN TestParallelTest
cannot run Terraform provider tests: 1 error occurred:
* expected ExactBinPath ("") to be an absolute path
FAIL github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource 1.132s
There was a problem hiding this comment.
Oh, that is a good catch! Let me fix that...
There was a problem hiding this comment.
Ah sorry, just submitted: #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39