Sort versions from releases JSON response #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
sort-versions
branch
from
09994e5
to
7400f7f
Compare
kmoe
approved these changes
Nov 11, 2021
radeksimko
force-pushed
the
sort-versions
branch
from
7400f7f
to
b05fe7c
Compare
radeksimko
force-pushed
the
sort-versions
branch
from
284fe72
to
76ee748
Compare
|
Thanks for the review, I added an E2E test as mocking would be a bit more difficult to add at this point to that particular piece of code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to provide some more consistent results when using the
releases.Listmethod, such that available versions are sorted from oldest to newest. This also consolidates the places where we parse raw version into*version.Version.