Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable CGO for CLI Linux builds #110

Merged
merged 1 commit into from
Feb 24, 2023
Merged

ci: Disable CGO for CLI Linux builds #110

merged 1 commit into from
Feb 24, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 23, 2023

We learnt the hard way elsewhere that go build builds dynamically linked (CGO) binaries by default, at least when it's being built on the same target OS/arch (in our case linux/amd64).

This ensures that we build the hc-install CLI still as static binary without CGO.

@radeksimko radeksimko merged commit 7c025fc into main Feb 24, 2023
@radeksimko radeksimko deleted the b-disable-cgo branch February 24, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants