Address review comments

hashicorp · May 29, 2024 · 51aeb2a · 51aeb2a
1 parent 277a65b
commit 51aeb2a
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 10 deletions.
diff --git a/build/git_revision.go b/build/git_revision.go
@@ -38,7 +38,7 @@ type GitRevision struct {
 	Product    product.Product
 	InstallDir string
 
-	// LicenseDir represents directory path where to install license files (required for enterprise versions, optional for OSS)
+	// LicenseDir represents directory path where to install license files.
 	// If empty, license files will placed in the same directory as the binary.
 	LicenseDir string
 

diff --git a/build/git_revision_test.go b/build/git_revision_test.go
@@ -25,10 +25,7 @@ var (
 func TestGitRevision_terraform(t *testing.T) {
 	testutil.EndToEndTest(t)
 
-	tempDir, err := os.MkdirTemp("", "license")
-	if err != nil {
-		t.Fatal(err)
-	}
+	tempDir := t.TempDir()
 
 	gr := &GitRevision{
 		Product:    product.Terraform,

diff --git a/checkpoint/latest_version.go b/checkpoint/latest_version.go
@@ -35,7 +35,7 @@ type LatestVersion struct {
 	SkipChecksumVerification bool
 	InstallDir               string
 
-	// LicenseDir represents directory path where to install license files (required for enterprise versions, optional for OSS)
+	// LicenseDir represents directory path where to install license files.
 	// If empty, license files will placed in the same directory as the binary.
 	LicenseDir string
 

diff --git a/releases/exact_version.go b/releases/exact_version.go
@@ -27,8 +27,8 @@ type ExactVersion struct {
 	InstallDir string
 	Timeout    time.Duration
 
-	// LicenseDir represents directory path where to install license files (required for enterprise versions, optional for OSS)
-	// If empty, license files will placed in the same directory as the binary.
+	// LicenseDir represents directory path where to install license files
+	// (required for enterprise versions, optional for Community editions).
 	LicenseDir string
 
 	// Enterprise indicates installation of enterprise version (leave nil for Community editions)

diff --git a/releases/latest_version.go b/releases/latest_version.go
@@ -27,8 +27,8 @@ type LatestVersion struct {
 	Timeout            time.Duration
 	IncludePrereleases bool
 
-	// LicenseDir represents directory path where to install license files (required for enterprise versions, optional for OSS)
-	// If empty, license files will placed in the same directory as the binary.
+	// LicenseDir represents directory path where to install license files
+	// (required for enterprise versions, optional for Community editions).
 	LicenseDir string
 
 	// Enterprise indicates installation of enterprise version (leave nil for Community editions)