remove defer keyword to avoid overhead #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Oct 23, 2019
full diff: hashicorp/golang-lru@0fb14ef...v0.5.3 - hashicorp/golang-lru#53 remove defer keyword to avoid overhead - hashicorp/golang-lru#56 lru.Get(): avoid nil pointer dereference - hashicorp/golang-lru#57 Adds LRU cache resize - hashicorp/golang-lru#58 lru: don't kill the return values of Remove and RemoveOldest Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Oct 24, 2019
full diff: hashicorp/golang-lru@0fb14ef...v0.5.3 - hashicorp/golang-lru#53 remove defer keyword to avoid overhead - hashicorp/golang-lru#56 lru.Get(): avoid nil pointer dereference - hashicorp/golang-lru#57 Adds LRU cache resize - hashicorp/golang-lru#58 lru: don't kill the return values of Remove and RemoveOldest Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Dec 10, 2019
full diff: hashicorp/golang-lru@0fb14ef...v0.5.3 - hashicorp/golang-lru#53 remove defer keyword to avoid overhead - hashicorp/golang-lru#56 lru.Get(): avoid nil pointer dereference - hashicorp/golang-lru#57 Adds LRU cache resize - hashicorp/golang-lru#58 lru: don't kill the return values of Remove and RemoveOldest Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Dec 12, 2019
full diff: hashicorp/golang-lru@0fb14ef...v0.5.3 - hashicorp/golang-lru#53 remove defer keyword to avoid overhead - hashicorp/golang-lru#56 lru.Get(): avoid nil pointer dereference - hashicorp/golang-lru#57 Adds LRU cache resize - hashicorp/golang-lru#58 lru: don't kill the return values of Remove and RemoveOldest Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 6, 2020
full diff: hashicorp/golang-lru@0fb14ef...v0.5.3 - hashicorp/golang-lru#53 remove defer keyword to avoid overhead - hashicorp/golang-lru#56 lru.Get(): avoid nil pointer dereference - hashicorp/golang-lru#57 Adds LRU cache resize - hashicorp/golang-lru#58 lru: don't kill the return values of Remove and RemoveOldest Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 4b267469b9b4769ac5f8a2cf3fa5e640efdc201e Component: cli
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address improvement I brought up here.
based on https://medium.com/i0exception/runtime-overhead-of-using-defer-in-go-7140d5c40e32, we could remove the most of the
deferstatement to avoid overhead. This should boost the performance even more. (Let me know if we need a benchmark to prove it?)